Make many functions const#91
Merged
Merged
Conversation
The point is to set up repeated components or boilerplate before their use sites. The majority of these make sense as `const`. However, some functions such as those regarding state may not make sense as `const`.
hecrj
requested changes
Nov 30, 2019
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
However, some functions such as those regarding state may not make sense as const.
Yes, I believe the methods min, max, size, bounds, and is_focused should be left as is. I cannot picture a const use case for those. I have rarely used const fn, though. What do you think?
hecrj
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The point is to set up repeated components or boilerplate before their use sites.
The majority of these make sense as
const. However, some functions such as those regarding state may not make sense asconst.