Make scrolling behave like you'd expect it to#95
Merged
Conversation
Contributor
Author
|
Ohhh, i completely forgot about the null renderer! Lemme fix this really quickly |
hecrj
requested changes
Nov 30, 2019
Member
|
Oh, I forgot to mention that it'd be great if you could squash the |
f647a54 to
6b25b4d
Compare
Contributor
Author
|
Thank you for those changes, the idea of a |
Member
|
Awesome! Yes, let's merge this! 🎉 Thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds proper scrolling logic to the
scrollablewidget.Here i define a "floater" to be the element that you can drag around with your mouse to scroll.
The new behaviour is the following: