Client crash with Fabric Create #149
Description
Expected behavior
Game plays without a crash? That'd be the expected behavior, and tbh no idea why Factions is causing a crash, but sure enough based on it being all over the logs, I remove it and it works perfectly.
Observed/actual behavior
When you are creating a blaze burner by clicking on a blaze with an empty blaze burner, the client crashes. It does this when create and factions are on a single player world, as well as on a server. On server, it does not 'kill' the server. Replicated multiple times; When I remove faction mods from my client, blaze burner gets 'filled' properly and does not crash. Joined the server and attempted, and it crashese still. Removed it from server, no crash. Again no idea why this mod is affected by a game mechanic that to me has nothing to do with factions, but it's happening all the same :(
Versions:
fabric 1.20.1 release 18.2
factions-mc1.20.1-2.5.1
create-fabric-6.0.8.1+build.1744.mc1.20.1
(entire list of mods file versions available upon request)
Log as follows;
[12:55:28] [Netty Epoll Server IO #5/ERROR]: Exception occurred in netty pipeline java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1297.method_24515()" because "entity" is null at io.icker.factions.core.InteractionManager.onUseEntity(InteractionManager.java:133) ~[factions-mc1.20.1-2.5.1.jar:?] at io.icker.factions.api.events.PlayerEvents.lambda$static$0(PlayerEvents.java:24) ~[factions-mc1.20.1-2.5.1.jar:?] at net.minecraft.class_3244$Anonymous$e5a2d7acb14746e0b72a61bb7dec505f.method_34220(ServerPlayNetworkHandlerMixin.java:66) ~[?:?] at net.minecraft.class_2824$class_5910.method_34213(class_2824.java:146) ~[server-intermediary.jar:?] at net.minecraft.class_2824.method_34209(class_2824.java:66) ~[server-intermediary.jar:?] at net.minecraft.class_3244.handler$beo000$factions$onPlayerInteractEntity(class_3244.java:4995) ~[server-intermediary.jar:?] at net.minecraft.class_3244.method_12062(class_3244.java) ~[server-intermediary.jar:?] at net.minecraft.class_2824.method_12251(class_2824.java:53) ~[server-intermediary.jar:?] at net.minecraft.class_2824.method_11054(class_2824.java:13) ~[server-intermediary.jar:?] at net.minecraft.class_2535.method_10759(class_2535.java:175) ~[server-intermediary.jar:?] at net.minecraft.class_2535.method_10770(class_2535.java:160) ~[server-intermediary.jar:?] at net.minecraft.class_2535.channelRead0(class_2535.java:52) ~[server-intermediary.jar:?] at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:336) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:308) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:336) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:308) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:336) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:323) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:444) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:280) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[netty-codec-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) ~[netty-handler-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[netty-transport-4.1.82.Final.jar:?] at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:800) ~[netty-transport-classes-epoll-4.1.82.Final.jar:?] at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:499) ~[netty-transport-classes-epoll-4.1.82.Final.jar:?] at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:397) ~[netty-transport-classes-epoll-4.1.82.Final.jar:?] at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[netty-common-4.1.82.Final.jar:?] at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[netty-common-4.1.82.Final.jar:?] at java.lang.Thread.run(Thread.java:1583) ~[?:?] [12:55:28] [Server thread/INFO]: MTXRooster lost connection: Internal Exception: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1297.method_24515()" because "entity" is null [12:55:28] [Server thread/INFO]: MTXRooster left the game [12:55:28] [Server thread/INFO]: [voicechat] Disconnecting client MTXRooster
Steps/models to reproduce
Listed above but in brief (not that it gets more complicated), equip a blaze burner, right click on a blaze to capture it, factions mod crashes client.
Can produce video etc whatever will help, but with what I provided it is 100% reproducable in single AND multi(server) player.
Version
Versions:
fabric 1.20.1 release 18.2
factions-mc1.20.1-2.5.1
create-fabric-6.0.8.1+build.1744.mc1.20.1
(entire list of mods file versions available upon request)
Other
I kinda mentioned it all in the upper two text blocks.