Adjust colors of AvalonEdit built-in highlightings for dark themes #3138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrzesniewski
force-pushed
the
dark-theme-highlighting
branch
from
c9a5385 to
bca06d7
Compare
Member
|
Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3137
Problem
Built-in highlightings of AvalonEdit are meant to be used on a white background, and look wrong on a dark one.
Solution
Any comments on the approach taken, its consistency with surrounding code, etc.
This PR changes the colors provided by a highlighting, unless that highlighting comes from ILSpy itself.
The color is tweaked in the HSL color space, inverting the luminosity and desaturating the color a bit (as recommended by Material Design). A few coefficients are applied, I chose them after trying various solutions, as I couldn't find a known algorithm for switching a color for use in dark mode anywhere.
Which part of this PR is most in need of attention/improvement?
I basically made up the color adjustment function out of nowhere. If you know something better, I'd like to know.
At least one test covering the code changed
This only contains UI changes.
Here are a few examples:
PowerShell:
JSON:
Turns out, HTML is handled by ILSpy's highlighting for XML.