Skip to content

Conversation

@Applesauce314
Copy link
Contributor

it appears Fix #3263 added an accidental != instead of == and broke the derived types node.

no issue exists, but i can create one if desired

Problem

Derived type nodes where always empty with a build from latest version. Traced it to what appears to be a backwards null check != null vs == null.

Solution

  • Corrected the comparison, derived types tab is now populated
  • need someone to verify the original issue in ILSpy crash #3263 is still fixed by the resultant code. (I would expect it to be, but don't know how to check myself)
  • At least one test covering the code changed

it appears Fix icsharpcode#3263 added an accidental `!=` instead of `==` and broke the derived types node.
@siegfriedpammer
Copy link
Member

  • need someone to verify the original issue in ILSpy crash #3263 is still fixed by the resultant code. (I would expect it to be, but don't know how to check myself)

Yes, your fix is fine. Thanks for providing a PR.

@siegfriedpammer siegfriedpammer merged commit 5e7e677 into icsharpcode:master Sep 20, 2024
@Applesauce314 Applesauce314 mentioned this pull request Sep 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ILSpy crash

2 participants