-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Support disassembling single file bundle for ILSpy #3398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disassembling single file bundle for ILSpy #3398
Conversation
ea7f9a7 to
79d6545
Compare
|
What are the chances we can get this in during March? |
I have merged the change on the runtime repo side, however, it looks like the new package is going to depend on |
|
Although even today we "up" the dependency for SRM in ILSpy vs ICS.Decompiler, taking on a preview dependency for a RTM version of ours (your PR was dog-eared for 9.1) might be a hard pill to swallow. |
|
@cshung I suppose this https://www.nuget.org/packages/System.Reflection.Metadata/10.0.0-preview.3.25171.5 would be the new package? (to replace 9.0.1 here ILSpy/Directory.Packages.props Line 45 in 5428a9b
|
75abee7 to
b0f4fc5
Compare
Yes! Assuming we are going to upgrade SRM to 10, I have rebased my PR and upgraded the package. This PR is now functional to disassemble ready to run code in a single file bundle. |
|
ICSharpCode.Decompiler.csproj should not be touched - the "old" packages there are very much intentional (yes, a bog standard NuGet update will unknowingly wreak havoc) |
1c94194 to
2edccad
Compare
|
@christophwille, hello? |
|
@siegfriedpammer is working on moving ILSpy to. NET 10, that is why we postponed merging this PR. Sorry for not telling you. |
2edccad to
eaf0eca
Compare
eaf0eca to
9beb9cb
Compare
|
@cshung thanks and sorry it took so long! |
Problem
#3397
Solution
ReadyToRunReaderis updated in this PR to support disassembling input given as aImmutableArray<byte>.ReadyToRunReaderso that it can perform the disassembling duty.ReadyToRunReader.This change will NOT compile until we have the package updated, this CI is expected to fail for now.