-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Upgrade dotnet target framework to net10 #3500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
36bd5ad to
2dcfc05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the entire solution to target .NET 10.0, introduces support for C# 13 features (including “params collections”), and adjusts various build scripts and test infrastructure accordingly.
- Bump target frameworks and SDK versions from net8.0 to net10.0 across projects, scripts, and workflows
- Add a new decompiler setting for “params collections” (C# 13) and integrate it throughout the codebase
- Update CI workflows, pre-commit hooks, and test runner paths to use .NET 10 and preview tools
Reviewed Changes
Copilot reviewed 67 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| publishlocaldev.ps1, publish.ps1 | Updated output paths for net10.0 in local/dev scripts |
| global.json | SDK version bumped from 8.0.100 to 10.0.0 |
| *.csproj (multiple) | Changed <TargetFramework> to net10.0[-windows] |
| ILSpy/Properties/Resources*.resx | Added “DecompilerSettings.DecompileParamsCollections” |
| ILSpy/Languages/CSharpLanguage.cs | Added C# 13.0 to language versions |
| ICSharpCode.Decompiler/* | Hooks for new ParamsCollections option and types |
| ICSharpCode.Decompiler.Tests/* | New test cases and constants for C# 13 and params |
| .github/workflows/*.yml | Updated .NET version and restore flags |
| BuildTools/pre-commit | Bumped dotnet-format to 9.x |
| .gitmodules | Added branch = master |
Files not reviewed (1)
- ILSpy/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (2)
ILSpy/Properties/Resources.zh-Hans.resx:318
- The Chinese resource value for 'DecompilerSettings.DecompileParamsCollections' is empty; please provide an appropriate translation.
<data name="DecompilerSettings.DecompileParamsCollections" xml:space="preserve">
.gitmodules:4
- [nitpick] The submodule branch is set to 'master', but many repositories now use 'main' as the default; verify the upstream default branch to avoid mismatches when cloning.
branch = master
…upport unexpanded string.Concat calls.
ff2e3be to
2fb90b4
Compare
No description provided.