Make TargetFramework and TargetServices public #3501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Custom project writers cannot currently make use of TargetFramework and TargetServices because they're not public.
My specific use case is: I am using ILSpy in my Godot decompiler to add support for decompiling games with C# scripts. One of the quirks about building a C# project for Godot is that the SDK in the
csprojis labelled asGodot.NET.Sdk, and there are custom assemblies that are automatically included without references, so I had to make a custom project writer for this and pass it intoWholeProjectDecompiler.I currently have to copy a bunch of files, including these, because they're not public; since we explicitly provide the ability to pass in a custom project writer to the decompiler, I think that they should be made public so that others can make use of them.
Solution