Skip to content

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Sep 11, 2025

Problem

Resolves #3541

Resolves #3558

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
  • Which part of this PR is most in need of attention/improvement?
  • At least one test covering the code changed

@ds5678
Copy link
Contributor Author

ds5678 commented Sep 11, 2025

Weird. I wonder why the CI is failing on this pull request, but not my one from a couple days ago.

@siegfriedpammer
Copy link
Member

My guess would be that they updated the runner images and now .NET 10 RC1 is used by default, which has language version 14 as default, which probably turned the field keyword into a hard error instead of warning. But I am not entirely sure.

@ds5678
Copy link
Contributor Author

ds5678 commented Sep 11, 2025

Hopefully, that fixes it.

@ds5678
Copy link
Contributor Author

ds5678 commented Sep 11, 2025

I just ran all the unit tests locally. None failed.

@siegfriedpammer
Copy link
Member

Looks like this now depends on #3556 because GitHub decided to update the CI images... sorry for that.

@siegfriedpammer siegfriedpammer merged commit 9c39e9b into icsharpcode:master Sep 14, 2025
5 checks passed
@ds5678 ds5678 deleted the issue3541 branch September 14, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants