Improve Framework Id detection

[ds5678]

Problem

Discussed in #3580

Solution

• Any comments on the approach taken, its consistency with surrounding code, etc.
• Which part of this PR is most in need of attention/improvement?
  • I did not verify that the version used for .NET Core 1.0 and 1.1 is correct. (Enable detection of .NET version without TargetFrameworkAttribute #3580 (comment))
• At least one test covering the code changed

[ds5678]

@CreateAndInject

[CreateAndInject]

Seems we should check netstandard reference in the final, I think a .NET Core app reference a .NET Standard assembly will produce both System.Runtime and netstandard reference.

My code based on dnlib:

public static void GetTargetFramework(this ModuleDef module, out string framework, out Version version, out string profile) {
	if (module.Assembly != null && module.Assembly.TryGetOriginalTargetFrameworkAttribute(out framework, out version, out profile))
		return;
	profile = null;
	if (module.IsClr10) {
		framework = ".NETFramework";
		version = new Version(1, 0, 0, 0);
	}
	else if (module.IsClr11) {
		framework = ".NETFramework";
		version = new Version(1, 1, 0, 0);
	}
	else if (module.IsClr20) {
		framework = ".NETFramework";
		var asmRefs = module.GetAssemblyRefs().Cast<IAssembly>();
		if (module.Assembly != null)
			asmRefs = asmRefs.Append(module.Assembly);
		if (asmRefs.Any(x => x.IsSystemAssembly() && x.Version == new Version(3, 5, 0, 0)))
			version = new Version(3, 5, 0, 0);
		else if (asmRefs.Any(x => x.IsSystemAssembly() && x.Version == new Version(3, 0, 0, 0)))
			version = new Version(3, 0, 0, 0);
		else
			version = new Version(2, 0, 0, 0);
	}
	else if ((module.GetAssemblyRef("System.Runtime") ?? module.GetAssemblyRef("System.Private.CoreLib")) is { } netcore && netcore.Version >= new Version(4, 1, 0, 0)) {
		framework = ".NETCoreApp";
		version = (netcore.Version.Major, netcore.Version.Minor, netcore.Version.Build) switch {
			(4, 1, 0) => new Version(1, 0, 0, 0),
			(4, 2, 0) => new Version(2, 0, 0, 0),
			(4, 2, 1) => new Version(2, 1, 0, 0),
			(4, 2, 2) => new Version(3, 1, 0, 0),
			_ => netcore.Version,
		};
	}
	else if (module.GetAssemblyRef("netstandard") is { } netstandard && module.GetAssemblyRef("mscorlib") is null) {
		framework = ".NETStandard";
		version = netstandard.Version;
	}
	else {
		framework = ".NETFramework";
		version = new Version(4, 0, 0, 0);
	}
}

[ds5678]

@CreateAndInject good now?

[CreateAndInject]

@CreateAndInject good now?

It's worse. I said check netstandard reference in final, but you check System.Runtime in final

[CreateAndInject]

@CreateAndInject good now?

It's worse. I said check netstandard reference in final, but you check System.Runtime in final

Let me say: System.Runtime + netstandard = .NET Core

[ds5678]

@CreateAndInject good now?

It's worse. I said check netstandard reference in final, but you check System.Runtime in final

Let's say: System.Runtime + netstandard = .NET Core

Why wouldn't it be System.Runtime + netstandard = .NET Standard

[CreateAndInject]

@CreateAndInject good now?

It's worse. I said check netstandard reference in final, but you check System.Runtime in final

Let's say: System.Runtime + netstandard = .NET Core

Why wouldn't it be System.Runtime + netstandard = .NET Standard

.NET Standard project should not reference specificed framework(.NET Core/ .NET Framework)

[ds5678]

Better?

[CreateAndInject]

Maybe, I'm thinking if we should pick earliest or latest version.

[ds5678]

Maybe, I'm thinking if we should pick earliest or latest version.

Latest version is what was done before.

[ds5678]

@siegfriedpammer when you have time, can you review this?

[siegfriedpammer]

LGTM sorry for the wait!