Navigate visible history #3591

miloush · 2025-10-11T09:02:16Z

Implements #3582 to show history items:

siegfriedpammer · 2025-10-11T09:29:29Z

Why do we need a NavigationText property?

miloush · 2025-10-11T09:32:04Z

Because it differs from what is in the tree, it shows full types, members including type, and assembly name for some of the folders (screenshot first item)

miloush · 2025-10-11T09:35:34Z

I can also imagine it could be a method where you put current state and the text would differ on where you are (like same namespace or same assembly)

siegfriedpammer · 2025-10-11T09:40:33Z

I think I am fine with that. Does need to be in the SharpTreeNode base class? Also definitely needs a separator other than space...

siegfriedpammer · 2025-10-11T09:42:55Z

It's also important to use the settings-aware implementation for the node text that is used everywhere else.

miloush · 2025-10-11T09:46:56Z

It has a default implementation returning Text so no extra work for inheritors if the entry is to be the same as in the tree. NavigationState is holding SharpTreeNode nodes so that's why I put it there.

You can see in the changed files that it follows what Text is doing. The only "new syntax" is the space for the folders. What would you prefer? >?

With that said, I don't mind using Text directly if that was preferred. I just didn't find it too helpful for navigation.

siegfriedpammer · 2025-10-11T09:57:59Z

Maybe put the folder in parentheses?

I am not sure. I can have a closer look when I get home. Reviewing code on the phone is not ideal. 😅

miloush · 2025-10-11T10:31:08Z

I put the folder first and where it belongs in parentheses, looks better, see the updated screenshot.

miloush · 2025-10-11T13:19:07Z

I also tried to include module name in the metadata nodes but feel free to skip that commit. Done working on this PR until there is feedback to address.

siegfriedpammer · 2025-10-11T15:08:12Z

One thought I had: is it possible to get an actual dropdown toolbar button in WPF? Is this only included in some community library?

miloush · 2025-10-11T15:15:54Z

There is no built-in dropdown button in WPF. I considered creating a control for it (or retemplating combobox) but since the theme and styles are external it didn't seem worth it. We could also just have it as context menu on the normal buttons and that's it.

siegfriedpammer · 2025-12-01T16:48:58Z

ICSharpCode.Decompiler/Metadata/MetadataFile.cs

-						: metadata.GetString(metadata.GetModuleDefinition().Name);
+					if (metadata.IsAssembly)
+						value = metadata.GetString(metadata.GetAssemblyDefinition().Name);
+					else if (metadata.DebugMetadataHeader == null) // standalone debug metadata does not contain module table


probably should check Kind instead?

The GetModuleDefinition throws on non-null DebugMetadataHeader, so that felt like an appropriate check before invoking it.

I don't mind changing it to Kind check, but I would need some hint about which Kinds guarantee DebugMetadataHeader, as I don't know how to produce e.g. WebCIL to check.

siegfriedpammer · 2025-12-01T16:54:14Z

I am playing around with your PR and something I noticed:

this doesn't seem to be very useful... I think each item should include the top-level ancestor, maybe?

miloush · 2025-12-03T13:10:42Z

Yeah I am aware of that. I thought it is a rare if not adverse scenario where you would jump through the same nodes in different assemblies. I thought about adding the top-level info, but then all the items become cluttered with full assembly name for minimal benefit in rare cases. Next thing you come with will be same assembly names using different file locations, so I think the line needs to be drawn somewhere.
(to be fair I only considered adding assembly name rather than top node text, and some of the nodes, especially in the metadata bits, do not have assembly/module associated, so it didn't really help)

This is not intended to replace user's memory. You still know what you have been doing recently so you will have an idea where the items come from.

With that said, with the NavigationText we can fine tune this easily on per node basis. For example, for namespaces we could include assembly name.

I could also do some analysis when building the history list, and if the previous item "looks the same" but has different top level, append the top level.

siegfriedpammer · 2025-12-03T13:30:40Z

You are right. It's probably fine the way it's now.

Copilot

Pull request overview

This PR implements feature #3582 to add visible navigation history to the Back/Forward toolbar buttons. The implementation adds dropdown menus to these buttons that display a list of recently visited navigation states, allowing users to jump directly to a specific point in their navigation history rather than clicking through each step sequentially.

Key Changes:

Introduces NavigationText property to tree nodes for context-rich display in navigation history
Adds dropdown menu support to toolbar commands via the new IProvideParameterList interface
Enhances navigation commands (Back/Forward) with parameterized history navigation

Reviewed changes

Copilot reviewed 38 out of 39 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
ICSharpCode.ILSpyX/TreeView/SharpTreeNode.cs	Adds base `NavigationText` property that defaults to `Text`
ILSpy/NavigationState.cs	Implements `NavigationText` property to format navigation history display
ILSpy/NavigationHistory.cs	Exposes `BackList` and `ForwardList` properties for UI consumption
ILSpy/AssemblyTree/AssemblyTreeModel.cs	Updates `NavigateHistory` to support jumping to specific state
ILSpy/Commands/SimpleCommand.cs	Adds `IProvideParameterList` interface for toolbar dropdown support
ILSpy/Commands/BrowseBackCommand.cs	Implements `IProvideParameterList` to provide back history list
ILSpy/Commands/BrowseForwardCommand.cs	Implements `IProvideParameterList` to provide forward history list
ILSpy/Controls/MainToolBar.xaml.cs	Implements dropdown menu UI for commands with parameter lists
ILSpy/Themes/ThemeManager.cs	Adds `CreateToolBarToggleButtonStyle` method for toggle button styling
ILSpy/TreeNodes/*.cs (multiple files)	Overrides `NavigationText` to include contextual information (type names, parent assembly, etc.)
ILSpy/Metadata/*.cs (multiple files)	Overrides `NavigationText` to include module/file name context
ILSpy/Properties/Resources.*	Adds "Referenced Types" localized resource string
ICSharpCode.Decompiler/Metadata/MetadataFile.cs	Handles name retrieval for standalone debug metadata without module table

Files not reviewed (1)

ILSpy/Properties/Resources.Designer.cs: Language not supported

Comments suppressed due to low confidence (1)

ILSpy/NavigationState.cs:78

Default 'ToString()': NavigationState inherits 'ToString()' from 'Object', and so is not suitable for printing.

				return ToString();

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ILSpy/TreeNodes/PropertyTreeNode.cs

ILSpy/TreeNodes/MethodTreeNode.cs

ILSpy/TreeNodes/FieldTreeNode.cs

ILSpy/TreeNodes/EventTreeNode.cs

Copilot · 2025-12-14T17:37:00Z

ILSpy/Controls/MainToolBar.xaml.cs


+		static void PrepareParameterList(ContextMenu menu)
+		{
+			const int maximumParameterListCount = 20;


The hardcoded limit of 20 items should be extracted as a named constant at the class level for better maintainability. This makes it easier to adjust the limit and makes the purpose clearer.

ILSpy/AssemblyTree/AssemblyTreeModel.cs

Copilot · 2025-12-14T17:37:02Z

ILSpy/Commands/SimpleCommand.cs

+
+	public interface IProvideParameterList
+	{
+		IEnumerable ParameterList { get; }


The IProvideParameterList interface is missing XML documentation comments. Consider adding documentation to explain the purpose of the interface, when it should be implemented, and what each member returns. This would help future developers understand how to use this interface for toolbar dropdown menus.

Suggested change

public interface IProvideParameterList

{

IEnumerable ParameterList { get; }

/// <summary>

/// Provides a list of parameters for use in toolbar dropdown menus.

/// Implement this interface when you want to supply a list of selectable parameters

/// (e.g., for a toolbar dropdown) and provide display text for each parameter.

/// </summary>

public interface IProvideParameterList

{

/// <summary>

/// Gets the list of parameters to be displayed in the dropdown menu.

/// </summary>

IEnumerable ParameterList { get; }

/// <summary>

/// Returns the display text for the specified parameter.

/// </summary>

/// <param name="parameter">The parameter for which to get the display text.</param>

/// <returns>A string representing the display text for the parameter.</returns>

ILSpy/Commands/BrowseBackCommand.cs

ILSpy/Controls/MainToolBar.xaml.cs

Copilot · 2025-12-14T17:37:03Z

ILSpy/Controls/MainToolBar.xaml.cs

 					parameterBinding.ParameterBinding);
 			}

+			if (command is IProvideParameterList parameterList)


This assignment to parameterList is useless, since its value is never read.

Suggested change

if (command is IProvideParameterList parameterList)

if (command is IProvideParameterList)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

miloush · 2025-12-14T18:11:20Z

I addressed what I intend to.

siegfriedpammer · 2025-12-14T18:47:26Z

I ran another quick test and I think we can merge it like this. Thanky you very much for your contribution!

miloush added 2 commits October 11, 2025 09:50

Navigate visible history

a8def5b

fixing whitespace

74f4fdb

miloush added 2 commits October 11, 2025 11:27

Workaround for dismissing navigation menu

6b91fc3

Navigation menu folders formatting

ab2ff5a

miloush added 3 commits October 11, 2025 12:08

NavigationText for more nodes

6a10b33

Navigation list forward sort order

af73e85

NavigationText for metadata nodes

7f75589

christophwille added the UI label Oct 23, 2025

siegfriedpammer reviewed Dec 1, 2025

View reviewed changes

christophwille requested a review from Copilot December 14, 2025 17:29

Copilot started reviewing on behalf of christophwille December 14, 2025 17:30 View session

Copilot AI reviewed Dec 14, 2025

View reviewed changes

Apply suggestions from code review

c80c7de

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

siegfriedpammer merged commit 612c5bc into icsharpcode:master Dec 14, 2025
5 checks passed

-	public interface IProvideParameterList
-	{
-		IEnumerable ParameterList { get; }
+	/// <summary>
+	/// Provides a list of parameters for use in toolbar dropdown menus.
+	/// Implement this interface when you want to supply a list of selectable parameters
+	/// (e.g., for a toolbar dropdown) and provide display text for each parameter.
+	/// </summary>
+	public interface IProvideParameterList
+	{
+		/// <summary>
+		/// Gets the list of parameters to be displayed in the dropdown menu.
+		/// </summary>
+		IEnumerable ParameterList { get; }
+		/// <summary>
+		/// Returns the display text for the specified parameter.
+		/// </summary>
+		/// <param name="parameter">The parameter for which to get the display text.</param>
+		/// <returns>A string representing the display text for the parameter.</returns>

	if (command is IProvideParameterList parameterList)
	if (command is IProvideParameterList)

Uh oh!

Navigate visible history #3591

Navigate visible history #3591

Conversation

miloush commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

siegfriedpammer commented Oct 11, 2025

Uh oh!

miloush commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miloush commented Oct 11, 2025

Uh oh!

siegfriedpammer commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

siegfriedpammer commented Oct 11, 2025

Uh oh!

miloush commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

siegfriedpammer commented Oct 11, 2025

Uh oh!

miloush commented Oct 11, 2025

Uh oh!

miloush commented Oct 11, 2025

Uh oh!

siegfriedpammer commented Oct 11, 2025

Uh oh!

miloush commented Oct 11, 2025

Uh oh!

siegfriedpammer Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

miloush Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

siegfriedpammer commented Dec 1, 2025

Uh oh!

miloush commented Dec 3, 2025

Uh oh!

siegfriedpammer commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

miloush commented Dec 14, 2025

Uh oh!

siegfriedpammer commented Dec 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

miloush commented Oct 11, 2025 •

edited

Loading

miloush commented Oct 11, 2025 •

edited

Loading

siegfriedpammer commented Oct 11, 2025 •

edited

Loading

miloush commented Oct 11, 2025 •

edited

Loading