Replace GeneratePdbForAssembly with GeneratePdbForAssemblies to improve user experience and remove redundant code. #3630
+2
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve user experience and remove redundant code.
Member
|
Thank you very much, sorry for taking so long to look at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GeneratePdbForAssemblyfunction internally sets theInitialDirectoryof theSaveFileDialog, whereasGeneratePdbForAssembliesdoes not. This inconsistency causes confusion when users switch between batch and single-file PDB generation, as the behavior regarding the output directory (e.g., whether it remembers the last used folder) varies.Since the functionality of
GeneratePdbForAssembliesnow fully covers that ofGeneratePdbForAssembly, there is no longer any need to retain the latter.