Fix/unify code formatting#209
Closed
JAD-SVK wants to merge 1 commit into
Closed
Conversation
The code formatting contained tabs and (4) spaces formatting. In some parts the tabs had a different width, sometimes formatted spaces and tabulators to "fix" position, sometimes totally invalid formatting (incorrect count of tabulators/spaces).
piksel
requested changes
Jul 1, 2018
| for (int i = 0 ; i < matchLen; i++) { | ||
| if (window[strstart-1+i] != window[prevMatch + i]) | ||
| throw new SharpZipBaseException(); | ||
| hrow new SharpZipBaseException(); |
Member
There was a problem hiding this comment.
I think we want to keep the "t" in throw.
| /// <summary> | ||
| /// Get minimum Zip feature version required to extract this entry | ||
| /// </summary> | ||
| /// </summary |
Member
|
This got superseded by #283 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code formatting contains tabs and (4) spaces formatting.
In some parts the tabs had a different width. Some lines contained spaces and tabs to "fix" position, but unfortunately, sometimes totally invalid for different tab settings (incorrect count of tabulators/spaces).
No code was changed, only white space was unified. (At least the problems I found by randomly looking at the code.)
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.