refactor: fallback schedules #1209
Conversation
apps/antalmanac/src/routes/Home.tsx
Outdated
| <MuiPickersUtilsProvider utils={DateFnsUtils}> | ||
| <PatchNotes /> | ||
| <InstallPWABanner /> | ||
| {/* <InstallPWABanner /> */} |
There was a problem hiding this comment.
InstallPWABanner was already disabled via #1213, this just further ensures none of its logic is applied unnecessarily
There was a problem hiding this comment.
Just throw it on another PR. It's one line. I'll review it in a snap.
MinhxNguyen7
added
codefix
MinhxNguyen7
left a comment
MinhxNguyen7
left a comment
There was a problem hiding this comment.
This doesn't seem to work. I tried to load the test schedule (which has classes), and nothing showed up in the added pane.
|
@KevinWu098 Reminder |
MinhxNguyen7
left a comment
MinhxNguyen7
left a comment
There was a problem hiding this comment.
This is what I see when I try to load the user test, even without blocking requests. I think you broke schedule loading in general,
Have you tested this?
apps/antalmanac/src/routes/Home.tsx
Outdated
| <MuiPickersUtilsProvider utils={DateFnsUtils}> | ||
| <PatchNotes /> | ||
| <InstallPWABanner /> | ||
| {/* <InstallPWABanner /> */} |
There was a problem hiding this comment.
Just throw it on another PR. It's one line. I'll review it in a snap.
| } | ||
|
|
||
| deleteCustomEvent(customEventId: number, scheduleIndices: number[]) { | ||
| deleteCustomEvent(customEventId: number | string, scheduleIndices: number[]) { |
There was a problem hiding this comment.
Why is this suddenly accepting a string? What's the type for a custom event on the backend? It should just be consistent instead of allowing anything
There was a problem hiding this comment.
This fixes some type errors we've had for a while post-RDS
| */ | ||
| doesCustomEventExistInSchedule(customEventId: number, scheduleIndex: number) { | ||
| for (const customEvent of this.schedules.at(scheduleIndex)?.customEvents ?? []) { | ||
| doesCustomEventExistInSchedule(customEventId: string | number, scheduleIndex: number) { |
There was a problem hiding this comment.
Same thing about the types
Loading works locally — isn't staging broken? |
Oops. I forgot about that |
Summary
Refactors away the SkeletonSchedule from our (soon-to-be legacy) Schedules store to a Zustand store. Removes event emitters, updates logic for reading and writing skeleton schedules.
This PR largely removes the old event emitter + event listener + useEffect pattern we had in many of our components in favor of Zustand's useStore hook. In some cases, this required additional logic changes (e.g. ScheduleSelect), but the PR is mostly refactoring.
Test Plan
Skeleton Schedules trigger when a user's schedule cannot be fully loaded because the AnteaterAPI is down. This results in us only having access to select fields (what AA stores on our DB), which are primarily the schedule names, custom events, schedule notes, and the course ID of the added courses.
For testing, you'll need to block requests to the AnteaterAPI via Chrome Dev Tools, then attempt to load a schedule with courses added. Fallback does not trigger if there are no courses, as it would make no requests to the API. Blocking the keyword
websocshould work here.Fallback should trigger immediately when the API request fails, displaying schedules correctly and blocking features which could require API data (e.g. save, load, editing).
Issues
Closes #1208