PostHog Auth #1284
Open
PostHog Auth #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added PostHog tracking for new auth actions. These include:
Also, users on Google Auth will get identified across different actions, so we can track what a specific user does in PostHog.
Additionally, our previous implementation for PostHog probably was focused on fully replicating Google Analytics 1:1. These included reducing additional metadata into generic labels such as 'content': 0/1 and then adding comments on what those actually mean in
analytics.ts. This is not preferred, especially when PostHog can support custom metadata in each action log. This PR aims to improve that, although some parts of the implementation are still janky (Posthog has no typescript sdk).Test Plan
Go through each of the actions in the summary. Perform the action, and then verify that the correct data shows up in the PostHog activity log (It helps to filter URL to localhost only). This may take anywhere from a few seconds to a few minutes for each to go through so this might be a tedious process
Issues
Closes #1276