-
Notifications
You must be signed in to change notification settings - Fork 90
Feat: Enrollment Update Time Tooltip #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| <Help fontSize="small" /> | ||
| <Box display="flex" alignItems="center"> | ||
| {props.label} | ||
| {!isMobile && props.formattedTime && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we hide on mobile? iirc there was a discussion about how tricky it was to make responsive was it apart of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think because it's a hover tooltip and such a small feature that's really only used when someone's actively enrolling that it can just be waived for mobile. Do you think its needed for mobile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. I think as a rule of thumb the feature should be supported in some capacity. I think the added panel needs some redesign maybe it's something to loop ui/ux in with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, but I think that's something outside of the scope of this feature. I can easily include it if you want though, itll just be a tap to see the tooltip then - which might get finicky (like accidentally tapping it).
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentColumnHeader.tsx
Outdated
Show resolved
Hide resolved
|
Sorry for neglecting this. I wanted to loop in UI/UX because I want to do a redesign of the Added panel so we'll keep this in account |
Summary
Added time icon tooltip that displays the last time the enrollment status of a course was updated (last websoc call).

Moved the explanation of NOR (previously tooltip on enrollment header) to be a tooltip on the actual NOR text.

Test Plan
Issues
Closes #933