Next PWA #1349
Draft
Next PWA #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Serwist looks really cool! Excited for this PWA :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set up Next.js PWA for AntAlmanac.
Updated
app/manifest.tsaccording to PWA builder report card, addresses at least all warnings and adds other relevant fieldsAdded safe areas and other visual changes to make it look better on mobile.
Also i have no idea why pnpm-lock has 6k line diff lol
Test Plan
Use either an actual phone or Simulator from XCode tools to navigate to the deployment and add it to home screen as PWA. Test that safe areas are implemented and nothing is being visually blocked, and that the PWA functions as expected and there are no visual issues
I have no idea how this looks on an android phone, if we were planning to also put it on the play store..
Issues
Closes #
Future Followup
We should take nicer screenshots with graphics if they are going to be on our App Store listing