AANTS SST #1378
Open
AANTS SST #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinWu098
requested changes
Dec 21, 2025
Member
KevinWu098
left a comment
KevinWu098
left a comment
There was a problem hiding this comment.
Warning
I switched the base branch from aants-merge to main to review the code more easily. If you intended to merge it into aants-merge, changing the base branch may screw up the review comments, so do so after we resolve them
Added some thoughts mostly on code quality. The core logic and implementation make sense to me!
|
|
||
| import { SESv2Client, CreateEmailTemplateCommand } from '@aws-sdk/client-sesv2'; | ||
|
|
||
| const client = new SESv2Client({ region: 'us-east-2' }); |
Contributor
Author
There was a problem hiding this comment.
us-east-2 (Ohio) is the region we have SES setup on and the one my AWS account was delegated to. Not sure if this is correct/incorrect but it's just the way it was setup for me
IsaacNguyen
had a problem deploying
to
staging
GitHub Actions
Failure
IsaacNguyen
had a problem deploying
to
staging
GitHub Actions
Failure
IsaacNguyen
had a problem deploying
to
staging
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merged NextJS + SST migration into AANTS and migrated the AANTS CDK code to SST
Test Plan
Issues
I kept getting this evil error that was saying the
.eslintignorefile in the root directory was breaking because of a new version of .eslint, but that same file exists on main, so I don't know why it's breaking. Fiddled with changing the version of .eslint in the AANTS folder to no avail. Couldn't figure it out so Kevin just told me to uncomment the pre-commit hook.