Fix: Duplicate users created on sign up #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinWu098
approved these changes
Jan 6, 2026
Member
KevinWu098
left a comment
KevinWu098
left a comment
There was a problem hiding this comment.
Because it's a race condition, I don't know how to test it absolutely — but I trust that it works.
However, I think using refs to prevent race conditions is a bit of an antipattern (i.e. why do we have a race condition in the first place?). Still, I think this is fine... maybe a TODO (@alexespejo): investigate race condition source is warranted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a race condition when you first create your AA account two user rows are created.
Local dev:
Test Plan
Expected: Only 1 row should appear in the db for that user and all functionality should be the same
Issues
Closes #