feat: ✨ base 404 page implementation #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ethancha0
temporarily deployed
to
staging-213
GitHub Actions
Inactive
ethancha0
temporarily deployed
to
staging-213
GitHub Actions
Inactive
ethancha0
temporarily deployed
to
staging-213
GitHub Actions
Inactive
ethancha0
temporarily deployed
to
staging-213
GitHub Actions
Inactive
ethancha0
temporarily deployed
to
staging-213
GitHub Actions
Inactive
kylebtran
requested changes
Dec 2, 2025
Member
kylebtran
left a comment
kylebtran
left a comment
There was a problem hiding this comment.
Awesome work Ethan!
I have requested a small change to optimally utilize Next.js's capabilities alongside its best practices.
Thank you for putting in time to complete this PR!
ethanchao28
approved these changes
Dec 3, 2025
kylebtran
approved these changes
Dec 5, 2025
Member
kylebtran
left a comment
kylebtran
left a comment
There was a problem hiding this comment.
Thank you for reviewing the code! You did an excellent job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a 404 error page that displays "Page" or "Meeting" based on the URL.