Ewc specific responders availability #229
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import Image from "next/image"; | ||
| import Link from "next/link"; | ||
|
|
||
| export default function NotFound() { | ||
| return ( | ||
| <div className="flex min-h-screen items-center justify-center"> | ||
| <div className="flex h-fit w-fit items-center justify-center gap-2 rounded-md border border-blue-400 bg-blue-100 p-16 shadow-sm"> | ||
| <div className="flex flex-col items-center gap-3"> | ||
| <h2 className="text-2xl font-bold"> | ||
| Oops! Meeting Not Found | ||
| </h2> | ||
| <p className="text-gray-600"> | ||
| The Meeting you're looking for doesn't exist | ||
| or may have been moved | ||
| </p> | ||
|
|
||
| <div className="p-7"> | ||
| <Image | ||
| src="/ZotMeet_BLACK.png" | ||
| alt="ZotMeet Logo" | ||
| width={120} | ||
| height={120} | ||
| /> | ||
| </div> | ||
|
|
||
| <Link | ||
| href="/" | ||
| className="rounded-md border border-blue-400 bg-blue-600 p-4 text-white hover:bg-blue-500" | ||
| > | ||
| Return Home | ||
| </Link> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,34 @@ | ||
| import Image from "next/image"; | ||
| import Link from "next/link"; | ||
|
|
||
| export default function NotFound() { | ||
| return ( | ||
| <div className="flex min-h-screen items-center justify-center"> | ||
| <div className="flex h-fit w-fit items-center justify-center gap-2 rounded-md border border-blue-400 bg-blue-100 p-16 shadow-sm"> | ||
| <div className="flex flex-col items-center gap-3"> | ||
| <h2 className="text-2xl font-bold">Oops! Page Not Found</h2> | ||
| <p className="text-gray-600"> | ||
| The Page you're looking for doesn't exist or | ||
| may have been moved | ||
| </p> | ||
|
|
||
| <div className="p-7"> | ||
| <Image | ||
| src="/ZotMeet_BLACK.png" | ||
| alt="ZotMeet Logo" | ||
| width={120} | ||
| height={120} | ||
| /> | ||
| </div> | ||
|
|
||
| <Link | ||
| href="/" | ||
| className="rounded-md border border-blue-400 bg-blue-600 p-4 text-white hover:bg-blue-500" | ||
| > | ||
| Return Home | ||
| </Link> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,8 @@ export function GroupResponses({ | |
| isMobileDrawerOpen, | ||
| setIsMobileDrawerOpen, | ||
| setHoveredMember, | ||
| selectedMember, | ||
| toggleSelectedMember, | ||
| } = useGroupSelectionStore(); | ||
|
|
||
| const [blockInfoString, setBlockInfoString] = useState( | ||
|
|
@@ -38,7 +40,12 @@ export function GroupResponses({ | |
| } | ||
|
|
||
| const member = members.find((m) => m.memberId === memberId); | ||
| setHoveredMember(member ? member.memberId : null); | ||
| }; | ||
|
|
||
| const handleCheckboxChange = (memberId: string) => { | ||
| // Toggle the member in the selectedMember array | ||
|
Member
There was a problem hiding this comment. nit: the best comment is no comment. To elaborate, your code should be written in a way such that it is clear and self-documenting (i.e. does not need a comment to further clarify it). If this holds true, then comments should be reserved for truly complex, difficult to explain code. |
||
| toggleSelectedMember(memberId); | ||
| }; | ||
|
|
||
| const { availableMembers, notAvailableMembers } = useMemo(() => { | ||
|
|
@@ -156,8 +163,8 @@ export function GroupResponses({ | |
| </span> | ||
| </div> | ||
| <ul className="h-64 space-y-2 overflow-auto py-2 pl-8"> | ||
| {members.length > 0 ? ( | ||
| members.map((member) => ( | ||
| <li | ||
|
Member
There was a problem hiding this comment. issue: why was this changed? does this affect rendering logic? we still render |
||
| key={member.memberId} | ||
| className="cursor-pointer text-lg text-gray-800" | ||
|
|
@@ -168,13 +175,36 @@ export function GroupResponses({ | |
| handleMemberHover(null) | ||
| } | ||
| > | ||
| <div className="flex items-center gap-2"> | ||
| <input | ||
| className="cursor-pointer" | ||
| type="checkbox" | ||
|
Comment on lines
+179
to
+181
Member
There was a problem hiding this comment. repeat: this should be a shadcn checkbox |
||
| checked={selectedMember.includes( | ||
| member.memberId | ||
| )} | ||
| onChange={() => | ||
| handleCheckboxChange( | ||
| member.memberId | ||
| ) | ||
| } | ||
| onClick={(e) => | ||
| e.stopPropagation() | ||
| } | ||
| /> | ||
| <span | ||
| className={cn( | ||
| selectedMember.includes( | ||
| member.memberId | ||
| ) && "font-semibold" | ||
| )} | ||
| > | ||
| {member.displayName} | ||
| </span> | ||
| </div> | ||
| </li> | ||
| )) | ||
| ) : ( | ||
| <li className="text-sm italic text-gray-400"></li> | ||
|
Member
There was a problem hiding this comment. question: why are we rendering nothing in the case where we have no members? suggestion: if it is an improvement to not indicate there are no responders, you should describe why in your PR and show screenshots. Further, you do not need to have an "else" case for this, as list.map(), where list is empty, would simply render nothing anyways |
||
| )} | ||
| </ul> | ||
| </div> | ||
|
|
@@ -198,7 +228,32 @@ export function GroupResponses({ | |
| handleMemberHover(null) | ||
| } | ||
| > | ||
| <div className="flex items-center gap-2"> | ||
| <input | ||
|
Member
There was a problem hiding this comment. suggestion: this probably should be a shadcn |
||
| className="cursor-pointer" | ||
| type="checkbox" | ||
| checked={selectedMember.includes( | ||
| member.memberId | ||
| )} | ||
| onChange={() => | ||
| handleCheckboxChange( | ||
| member.memberId | ||
| ) | ||
| } | ||
| onClick={(e) => | ||
| e.stopPropagation() | ||
| } | ||
| /> | ||
| <span | ||
| className={cn( | ||
| selectedMember.includes( | ||
| member.memberId | ||
| ) && "font-semibold" | ||
|
|
||
| )} | ||
| > | ||
| {member.displayName} | ||
| </span> | ||
| </div> | ||
| </li> | ||
| )) | ||
| ) : ( | ||
|
|
||
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: comments may be redundant here