Conversation
gfm-extra.txt contains edge cases not covered by gfm-spec.txt, and is a temporary staging ground as gfm functionality is implemented
robacarp
left a comment
There was a problem hiding this comment.
This is great. I left one nitpicky comment. Thank you for your strategic approach to this.
| # NOTE(margret): Temporarily copying strikethrough specs | ||
| # describe_spec("fixtures/gfm-spec.txt", gfm: true) | ||
|
|
||
| describe_spec("fixtures/gfm-extra.txt", gfm: true) |
There was a problem hiding this comment.
I appreciate your strategic approach here, thank you.
My only suggestion is that this file be named something other than "gfm-extra". How about "working-gfm-spec.txt" or something similar?
There was a problem hiding this comment.
That would work for me. I also wanted a file to add GFM specs for stuff that wasn't covered by the normal spec (like leaving ~ if there's only one set around a char). I can split these into two different files as well.
There was a problem hiding this comment.
Actually, I think it'd be better to leave gfm-spec.txt as-is and instead of bringing pieces over to a new file piecemeal, to mark things in gfm-spec that don't/shouldn't pass as pending. Thoughts?
There was a problem hiding this comment.
Went with the latter as there are currently only ~36 failing tests in gfm-spec.txt
This pull request adds GitHub Flavored Markdown (GFM) strikethrough support (
~~hello~~=>hello).This also adds the
gfm-spec.txtdownloaded from here. To prevent a lot of broken specs that won't be fixed by this PR, the strikethrough specs have been copied togfm-extra.txttemporarily.