Skip to content

gfm task list / checkbox support#63

Merged
icyleaf merged 2 commits intoicyleaf:masterfrom
nobodywasishere:nobody/gfm-checkbox
May 25, 2024
Merged

gfm task list / checkbox support#63
icyleaf merged 2 commits intoicyleaf:masterfrom
nobodywasishere:nobody/gfm-checkbox

Conversation

@nobodywasishere
Copy link
Collaborator

@nobodywasishere nobodywasishere commented May 25, 2024

This pull request adds support for GFM task lists / checkboxes, as well as fixing some issues with spacing in gfm-spec.txt, bringing the current number of pending tests down to 30.

require "./src/markd"

markdown = <<-MD
# Hello Markd

> Yet another markdown parser built for speed, written in Crystal, Compliant to CommonMark specification.
> - [ ] check box

- [ ] one
  - [x] two
    - [ ] three
MD

options = Markd::Options.new(gfm: true)
puts Markd.to_html(markdown, options)
<h1>Hello Markd</h1>
<blockquote>
<p>Yet another markdown parser built for speed, written in Crystal, Compliant to CommonMark specification.</p>
<ul>
<li><input disabled="" type="checkbox"> check box</li>
</ul>
</blockquote>
<ul>
<li><input disabled="" type="checkbox"> one
<ul>
<li><input checked="" disabled="" type="checkbox"> two
<ul>
<li><input disabled="" type="checkbox"> three</li>
</ul>
</li>
</ul>
</li>
</ul>

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 25, 2024
… fail

vscode has a tendency to just replace all &nbsp; with space
@icyleaf icyleaf merged commit 4a1e0fa into icyleaf:master May 25, 2024
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 25, 2024
@nobodywasishere nobodywasishere deleted the nobody/gfm-checkbox branch May 25, 2024 13:30
@icyleaf icyleaf mentioned this pull request Mar 2, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Merged Pull Request has been merged successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants