Open
Conversation
trafico-bot
bot
added
the
🚧 WIP
ralsina
force-pushed
the
footnotes
branch
2 times, most recently
from
d9a392d to
ac17b63
Compare
trafico-bot
bot
added
🔍 Ready for Review
Collaborator
|
If this is in a stable place, I'm fine to merge this now and sort out the issues in followup PRs. |
Contributor
Author
|
It implements some basic cases and doesn't seem to break anything at least :-) |
Contributor
Author
|
I am working now on finishing this. |
Contributor
Author
|
Weird, tests were passing before, fixing. |
- Fix bug where footnote hash iteration used underscore placeholder but referenced outer scope 'title' variable - Use explicit 'footnote_title' variable to avoid shadowing and properly capture hash keys - Replace deprecated @options.gfm with @options.gfm? - Replace deprecated URI.encode with encode_id_component helper for footnote IDs This fixes 4 test failures related to undefined footnote references and nested footnotes, and resolves 5 deprecation warnings. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
Sigh, I asked the LLM to fix ameba warnings and it choose wrong on every one of them. Fixed now :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is, AFAIK a full implementation of footnotes as per the specs we have on the repo.