Skip to content

Change the example with the "useless use of echo" and backticks#293

Open
Strahinja wants to merge 1 commit intoidank:masterfrom
Strahinja:master
Open

Change the example with the "useless use of echo" and backticks#293
Strahinja wants to merge 1 commit intoidank:masterfrom
Strahinja:master

Conversation

@Strahinja
Copy link

One of the examples on the front page,

file=$(echo `basename "$file"`)

is using the deprecated backticks and "useless use of echo". As explainshell.com is likely to be used for learning shell, this potentially teaches those bad habits.

This PR changes the example to

name=$(printf "%s@%s" "$(id -nu)" "$(uname -n)")

…milar

Signed-off-by: Страхиња Радић <contact@strahinja.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant