Skip to content

rebuild family determination on failed request #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacobkagon merged 6 commits into from
Dec 8, 2025
Merged

rebuild family determination on failed request #5940

jacobkagon merged 6 commits into from
Dec 8, 2025

Conversation

@vkghub
Copy link
Contributor

@vkghub vkghub commented Dec 5, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868gfy935

A brief description of the changes:

Current behavior: Family eligibility determination is not getting build after RRV request

New behavior: Re-build Family eligibility determination after RRV request

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@vkghub vkghub self-assigned this Dec 5, 2025
@vkghub vkghub added the bugfix label Dec 5, 2025
@vkghub vkghub marked this pull request as ready for review December 8, 2025 14:08
jacobkagon
jacobkagon approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@jacobkagon jacobkagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

@jacobkagon jacobkagon enabled auto-merge (squash) December 8, 2025 14:18
@jacobkagon jacobkagon merged commit 834e0c7 into trunk Dec 8, 2025
270 of 276 checks passed
@jacobkagon jacobkagon deleted the CU-868gfy935_v2 branch December 8, 2025 14:38
sri49 pushed a commit that referenced this pull request Dec 11, 2025
@vkghub @sri49
rebuild family determination on failed request (#5940)
aab8dcb 
* rebuild family determination on failed request

* fix spec

* fix more specs

* spec fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayreddy519 jayreddy519 jayreddy519 approved these changes

@jacobkagon jacobkagon jacobkagon approved these changes

Assignees

@vkghub vkghub

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vkghub @jayreddy519 @jacobkagon