Skip to content

Conversation

@vkghub
Copy link
Contributor

@vkghub vkghub commented Dec 26, 2023

@vkghub vkghub marked this pull request as ready for review December 26, 2023 16:56
@vkghub vkghub self-assigned this Dec 26, 2023
@saikumar9 saikumar9 requested a review from TreyE December 26, 2023 17:07
@saikumar9 saikumar9 changed the title remove unused gem resque-bus removes unused gem resque-bus Dec 26, 2023
@saikumar9 saikumar9 enabled auto-merge (squash) December 26, 2023 17:16
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkghub I think we should delete the file lib/event_source/tasks/event_source.rake which is related to the gem resque-bus. Please confirm.

@saikumar9 I think it is not required, I will remove.

@vkghub vkghub requested a review from saikumar9 December 26, 2023 18:48
Copy link
Contributor

@raghuramg raghuramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikumar9 saikumar9 merged commit e2cb69b into trunk Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants