-
Notifications
You must be signed in to change notification settings - Fork 22
ENH: write and read native coordinates in VTK #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
79f2285 to
d6960c9
Compare
|
I rewrote the branch history to help bisect the current issue: vtk outputs are corrupted and unreadable. The breaking commit is eaa2322 (as one might expect). I also changed back the reading logic so that
|
|
I think a fundamental issue with our current approach is that we're writing arbitrary fields in the style of the VTK header but outside said header. We need to either:
I think option 2) is preferable but I don't know if it's allowed. |
|
found a problem downstream: https://github.com/volodia99/nonos/pull/371#issuecomment-2459596390 |
|
all clear, the issue was downstream |
Co-authored-by: volodia99 <gaylor.wafflard@univ-grenoble-alpes.fr>
0661cea to
1087e85
Compare
Co-authored-by: Clément Robert <cr52@protonmail.com>
|
Thanks for this improvement, that seems to fix the issue of reconstructing the cell coordinates from the VTK cartesian coordinates. However, I think there is a regression: the original version of This new implementation misses that last rightmost face ( |
|
Actually, my previous comment was incorrect, it does include the last rightmost face. So we're good to go. |
ENH: write and read native coordinates in VTK (#292)
|
Manually merged as github wouldn't let me do it from their website. |
No description provided.