Skip to content

Bump up to Kokkos 4.5 #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glesur merged 2 commits into from
Dec 16, 2024
Merged

Bump up to Kokkos 4.5 #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4b2d46
bump up to kokkos4.5
glesur Dec 4, 2024
1453cca
remove force disable cuda malloc async following update to 4.5
glesur Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ include(SetRequiredBuildSettingsForGCC8)
#Idefix requires Cuda Lambdas (experimental)
if(Kokkos_ENABLE_CUDA)
set(Kokkos_ENABLE_CUDA_LAMBDA ON CACHE BOOL "Idefix requires lambdas on Cuda" FORCE)
set(Kokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC OFF CACHE BOOL "Disable Async malloc to avoid bugs on PSM2" FORCE)
# CUDA_MALLOC_ASYNC disbaled by default in Kokkos 4.5, so not required here
#set(Kokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC OFF CACHE BOOL "Disable Async malloc to avoid bugs on PSM2" FORCE)
endif()

# Add kokkos CMAKE files (required early since these set compiler options)
Expand Down
2 changes: 1 addition & 1 deletion src/kokkos
Open in desktop
Submodule kokkos updated 654 files
Loading