Improve grid coarsening checks #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce memory footprint by copying only what's needed
Merged
glesur
added a commit
that referenced
this pull request
Apr 16, 2025
## [2.2.01] 2025-04-16 ### Changed - Fix a bug that led to instabilities in the RKL scheme with very small grid spacings (#323) - Fix a bug that prevented Idefix from running with Sycl backend (required on Intel GPUs) (#331) - Fix an error that led to incorrect electrical current regularisation around the polar axis in non-Ideal MHD (#333) - Improve div(B) checks with a dimensionless implementation, avoiding too large divB errors in grids with large stretch factors (#334) ### Added - Time-Implicit drag for multiple dust species, preventing small time steps for strongly coupled dust grains (#321) - Collisionless heat flux added to the Braginskii module (#317) - New global `idfx::DumpArray` debugging function to dump any Idefix array into a numpy array that can read from python (#318) - Automatic benchmark plots in the documentation (#319) - More CI tests of grid coarsening (#329) - Dump outputs based on wallclock time (#335) --------- Co-authored-by: Victor Réville <victorreville@gmail.com> Co-authored-by: Hal Bal <vreville@irap.omp.eu> Co-authored-by: Jean Kempf <jean.kempf@irap.omp.eu> Co-authored-by: Victor Réville <47865059+vreville@users.noreply.github.com> Co-authored-by: Marc Coiffier <marc.coiffier@univ-grenoble-alpes.fr> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check coarsening inside ghost zones, and detect Nan.
Reduce memory footprint by copying only what's needed (and not the full datablock)
possibly address issues like #328