fix(cli): Handle failure to login to registry #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes how the CLI handles a failure to login to the docker registry by catching exceptions from the docker login command.
- Wraps the docker login command in a try-except block
- Logs a warning and continues execution on login failure
idoudali
force-pushed
the
idoudalis/fix-docker-login
branch
from
c7cbba0 to
84c9381
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adjusts the CLI's docker login process to gracefully handle login failures by logging errors and continuing container startup.
- Wraps the docker login command execution in a try/except block.
- Logs command execution details safely, redacting sensitive information when applicable.
|
|
||
| # Capture and log the output of the command | ||
| result = subprocess.run(docker_login_cmd, shell=True, check=True, text=True, capture_output=True) | ||
| logging.info(f"Docker login output: {result.stdout}") |
There was a problem hiding this comment.
Ensure that logging the raw output from the docker login command does not expose sensitive information inadvertently.
If we cannot connect to the docker registry, then continue with trying to building the docker image or re-using one from the local registry.
idoudali
force-pushed
the
idoudalis/fix-docker-login
branch
from
84c9381 to
0945c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we cannot connect to the docker registry, then continue with trying to building the docker image or re-using one from the local registry.