Personal Improvements #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hooks (ruff, mypy) and repo checks; add pre-commit dep;
tidy whitespace; update lockfile
- Add .pre-commit-config.yaml:
* Ruff: ruff --fix and ruff-format
* Mypy: uses pyproject.toml, scopes to src/, excludes
src/fact/cli.py
* Common checks: check-merge-conflict, check-added-large-files,
end-of-file-fixer, trailing-whitespace, debug-statements,
check-yaml (excludes mkdocs.yml), check-toml, check-case-conflict,
check-symlinks, detect-private-key
- Add pre-commit to lint dependency group in pyproject.toml
- Normalize EOF in .gitattributes
- Trim trailing whitespace in README.md and docs/index.md
- Update uv.lock to include pre-commit and deps (cfgv, identify,
nodeenv) and refresh resolution
idoudali
force-pushed
the
idoudalis/personal-improvements
branch
2 times, most recently
from
fb81d85 to
de53663
Compare
- Add .cursor/rules/commit-messages.md documenting Conventional Commits usage - Add .cursor/rules/python.md with project-specific Python rules (tooling, layout, style, typing, tests, docs, CLI, security) - Update .pre-commit-config.yaml to add conventional-pre-commit commit-msg hook (v4.2.0)
idoudali
force-pushed
the
idoudalis/personal-improvements
branch
from
de53663 to
879254b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds development tooling improvements to enhance code quality and consistency. The changes introduce pre-commit hooks for automated linting and formatting, along with Cursor IDE configuration rules for Python development and conventional commit message standards.
- Adds pre-commit hooks for code quality enforcement including ruff, mypy, and conventional commits
- Introduces Cursor IDE rules for Python development best practices and commit message formatting
- Updates project documentation to reflect the fork status and new tooling additions
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Adds pre-commit to lint dependencies and includes mypy configuration note |
| README.md | Updates title to indicate fork status and documents new tooling additions |
| .pre-commit-config.yaml | Configures pre-commit hooks for linting, formatting, type checking, and commit message validation |
| .cursor/rules/python.md | Establishes Python development guidelines and tooling usage for Cursor IDE |
| .cursor/rules/commit-messages.md | Defines Conventional Commits specification for consistent commit messages |
| - id: mypy | ||
| args: | ||
| - "--config-file=pyproject.toml" | ||
| - "src" |
There was a problem hiding this comment.
The mypy exclusion for 'src/fact/cli.py' should be documented with a comment explaining why this file is excluded from type checking.
Suggested change
| - "src" | |
| - "src" | |
| # Exclude src/fact/cli.py from type checking due to dynamic CLI argument parsing that is difficult to type-check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add