Defensively create collections in JAXB getters#139
Closed
evdherberg wants to merge 2 commits intoigniterealtime:mainfrom
Closed
Defensively create collections in JAXB getters#139evdherberg wants to merge 2 commits intoigniterealtime:mainfrom
evdherberg wants to merge 2 commits intoigniterealtime:mainfrom
Conversation
guusdk
force-pushed
the
feature/137-defensive-collection-getters
branch
from
28ab188 to
ca8498e
Compare
guusdk
force-pushed
the
feature/137-defensive-collection-getters
branch
from
ca8498e to
71ddc64
Compare
guusdk
force-pushed
the
feature/137-defensive-collection-getters
branch
from
71ddc64 to
84a071e
Compare
Member
|
I have added the same defensive code to all other getters in entities, and rebased this PR to the latest main branch However, the more I think about this, the more I wonder if this doesn't fix a problem, but hides one. I wonder if @evdherberg was initially running into the same issue that is causing #15. For that, PR #131 is created, which should fix things. I'd like to merge #131 first, and see if that prevents the issue that Emiel was experiencing. If that's the case, then there should no longer be a need for this PR. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137. Well, partly. I only made this change for the entity where the problem manifested itself for me. I don't have time now to check all entities. If that's considered necessary, then this PR should remain open until that's done.