fixes #141: Reduce MUC affiliation boilerplate#142
Merged
guusdk merged 1 commit intoigniterealtime:mainfrom Aug 2, 2022
Merged
fixes #141: Reduce MUC affiliation boilerplate#142guusdk merged 1 commit intoigniterealtime:mainfrom
guusdk merged 1 commit intoigniterealtime:mainfrom
Conversation
This replaces very similar classes with one that takes an affiliation-type as a dynamic type.
Note that the backwards compatiblity test that we had for just one of these types ('members') still passes. This is a good indication that functional changes related to this change are, hopefully, minimal or absent.
guusdk
force-pushed
the
141_reduce-muc-affiliation-boilerplate
branch
from
381a88c to
90f0c84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces very similar classes with one that takes an affiliation-type as a dynamic type.
Note that the backwards compatiblity test that we had for just one of these types ('members') still passes. This is a good indication that functional changes related to this change are, hopefully, minimal or absent.
This results in a much smaller list of endpoints, as shown here:
