Fixes compatibility issue with Openfire 4.9.0#201
Merged
guusdk merged 1 commit intoigniterealtime:mainfrom Oct 5, 2024
Merged
Conversation
This replaces API of Openfire that was removed in Openfire 4.9.0. The plugin remains compatible with Openfire 4.8.0 and later. Fixes igniterealtime#200
Member
|
Is there a way to CI our way to detecting things like this? |
Member
Author
|
I would love to find a way to automatically detect issues like this, not just for this plugin, but also for all other plugins. Lets discuss that not in scope of just this RESTAPI issue. I've created a new ticket here: igniterealtime/ci-tooling#1 |
Fishbowler
approved these changes
Oct 5, 2024
Member
Fishbowler
left a comment
Fishbowler
left a comment
There was a problem hiding this comment.
Works on my machine.
Can get into settings, configure for shared key auth, and have fired a sample of GET requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces API of Openfire that was removed in Openfire 4.9.0. The plugin remains compatible with Openfire 4.8.0 and later.
Fixes #200