Closed
Conversation
abreckner
reviewed
Apr 28, 2020
|
|
||
| require "nokogiri" | ||
|
|
||
| require "xpm_ruby/version" |
Contributor
There was a problem hiding this comment.
Looks like this line is in twice? I moved it down earlier because I wanted to put them in alphabetical order. ;) My bad, you might not have noticed...
Contributor
Author
There was a problem hiding this comment.
ah sorry merge conflict I'll fix that up.
abreckner
reviewed
Apr 28, 2020
| :signed_tax_authority, :tax_agent, :agency_status, :return_type, | ||
| :prepare_activity_statement, :prepare_tax_return | ||
|
|
||
| def initialize(name:, email: nil, |
Contributor
There was a problem hiding this comment.
Would it make sense to pass in the XML hash instead of each attribute?
Contributor
There was a problem hiding this comment.
Ah wait this is a different client object?
Merged
Contributor
Author
|
Closing in favour of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation (Why)
https://ignitionapp.slack.com/archives/C0125F6R353/p1587950291147900
Implementation (How)
Nokogiri::Xml::Builderto build a minimal client (with name) documentConnection.postinterfaceNote: I've moved a few things around in this PR because
models/client.rbwasn't making much sense.clientpassed in to.addhas a different structure from theclientresponse (same as the.getresponse). Trying to merge these differences into one model will break conformity.