Skip to content

remove faraday version#20

Merged
bedrock-adam merged 2 commits intomasterfrom
gemspec/faraday/remove_version
Apr 29, 2020
Merged

remove faraday version#20
bedrock-adam merged 2 commits intomasterfrom
gemspec/faraday/remove_version

Conversation

@bedrock-adam
Copy link
Contributor

Motivation (Why)

Fix bundle install in main app

Resolving dependencies.......
Bundler could not find compatible versions for gem "faraday":
  In snapshot (Gemfile.lock):
    faraday (= 0.15.4)
  In Gemfile:
    chartmogul-ruby was resolved to 1.5.0, which depends on
      faraday (~> 0.15.0)
    xpm_ruby was resolved to 0.1.0, which depends on
      faraday (~> 1)
Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

Copy link
Contributor

@abreckner abreckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but check if you have to also check in the Gemfile.lock.

@bedrock-adam
Copy link
Contributor Author

Great catch on the Gemfile.lock 👍

@bedrock-adam bedrock-adam merged commit 546bb0d into master Apr 29, 2020
@bedrock-adam bedrock-adam deleted the gemspec/faraday/remove_version branch April 29, 2020 04:14
lankz pushed a commit that referenced this pull request Jun 10, 2025
* remove faraday version

* add Gemfile.lock
lankz pushed a commit that referenced this pull request Jun 10, 2025
* remove faraday version

* add Gemfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants