Conversation
| rspec (~> 3.0) | ||
| rubocop (= 0.77.0) | ||
| rubocop-rspec | ||
| vcr |
There was a problem hiding this comment.
Wondering if we should specify a major version?
There was a problem hiding this comment.
I generally prefer to let bundler handle gem versioning for me and only specify a version if something breaks (and I need to hold it down). Also in a gem you have to be very careful when specifying versions because it might clash with the version used by the main app.
There was a problem hiding this comment.
I just noticed I had actually specified versions before, but that was copied and pasted from the client success gem. I might actually remove them in another PR. :)
There was a problem hiding this comment.
Yeah that's a great point @abreckner!
I think I may have added versions but that makes sense let's remove I'll keep them out of the gemfile too.
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Ah did I have the spec files in the wrong directory?
bedrock-adam
left a comment
bedrock-adam
left a comment
There was a problem hiding this comment.
Awesome work Tony 👍 🚀
Adding VCR spec to Staff List. IGNT-3573
2 participants
This PR adds the VCR gem and updates the Staff.list spec to use it.
There are a few extra cautionary steps we need to make in order to avoid checking in sensitive data (which I updated in the read me).