Conversation
rudylee
reviewed
Mar 8, 2021
lib/xpm_ruby/category.rb
Outdated
| module Category | ||
| extend self | ||
|
|
||
| class Error < Error; end |
Contributor
There was a problem hiding this comment.
Suggested change
| class Error < Error; end | |
| class Error < StandardError; end |
Contributor
There was a problem hiding this comment.
Actually why do we need to define this here ? I noticed other modules also have this.
Contributor
Author
There was a problem hiding this comment.
yeah, I think it might be a severe case of 🍝
Contributor
There was a problem hiding this comment.
@abreckner might be able to answer. I'll say just delete it if we don't use it.
rudylee
approved these changes
Mar 8, 2021
Contributor
rudylee
left a comment
rudylee
left a comment
There was a problem hiding this comment.
Looks good, just one question about the error class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent (What)
Add Category
https://developer.xero.com/documentation/practice-manager/categories
Motivation (Why)
We want
XpmRuby::Categoryfor our new cool featuresImplementation (How)
Consequence