[NOJIRA] fix when API doesn't return an array for list methods#55
Merged
[NOJIRA] fix when API doesn't return an array for list methods#55
Conversation
rudylee
approved these changes
Mar 17, 2021
Contributor
rudylee
left a comment
There was a problem hiding this comment.
I assume it can happen not just with categories but other methods.
I guess it's better if you can confirm this since you don't have spec to check if this is true or not.
Contributor
Author
|
@rudylee |
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
[NOJIRA] fix when API doesn't return an array for list methods
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
[NOJIRA] fix when API doesn't return an array for list methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent (What)
Sometimes in response for list methods XPM doesn't return a "second-level key". For example, we expect the XML response to have structure
Categories -> Category -> contentbut we receive justCategories.A real life example of such response:
I assume it can happen not just with categories but other methods.
Motivation (Why)
gem fails with https://sentry.io/organizations/ignition/issues/2260233094/?project=1314270&referrer=slack
Implementation (How)
Consequence