Skip to content

Add update, delete and add methods to Staff#59

Merged
rmustafin merged 2 commits intomasterfrom
ramil/staff_add__update_delete
Apr 19, 2021
Merged

Add update, delete and add methods to Staff#59
rmustafin merged 2 commits intomasterfrom
ramil/staff_add__update_delete

Conversation

@rmustafin
Copy link
Contributor

Intent (What)

https://developer.xero.com/documentation/practice-manager/staff

Adds Staff Add, Update and Delete methods

Motivation (Why)

I want to use them very much

Implementation (How)

Consequence

@rmustafin rmustafin requested a review from a team as a code owner April 16, 2021 11:22
module Staff
Add = Types::Hash.schema(
Name: Types::String,
Address?: Types::String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is address list a single text field, not separated by line, city, etc?

As usual their API documentation doesn't actually give you a useful example... 😄

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, their docs are...interesting 😄

@rmustafin rmustafin merged commit 075b8fc into master Apr 19, 2021
@rmustafin rmustafin deleted the ramil/staff_add__update_delete branch April 19, 2021 05:24
lankz pushed a commit that referenced this pull request Jun 10, 2025
Add update, delete and add methods to Staff
lankz pushed a commit that referenced this pull request Jun 10, 2025
Add update, delete and add methods to Staff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants