Conversation
rudylee
force-pushed
the
connection-timeout
branch
from
b1e4895 to
f792c61
Compare
rudylee
force-pushed
the
connection-timeout
branch
from
f792c61 to
d2acf66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent (What)
This PR adds a new error class
ConnectionTimeoutto the XPM ruby gem. We will raise this exception when we get Faraday::TimeoutError exception when sending request to XPM API.This way we don't leak the abstraction and make sure the main app only aware of
XpmRubyerror classes not the library underneath it.Motivation (Why)
I was investigating an error with Workflow job stuck in deploying yesterday. I discovered that the reason why the job was stuck in deploying is because we get timeout error when trying to create the job in XPM.
The plan is to merge this PR and add a logic to requeue the deploy job to XPM sidekiq job if we get the timeout error.