Unrestrict dry-types version and fix changes#66
Merged
chrisrbnelson merged 2 commits intomasterfrom Aug 6, 2021
Merged
Conversation
walhalign
approved these changes
Aug 6, 2021
411f789 to
3746182
Compare
3746182 to
390b00e
Compare
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Unrestrict dry-types version and fix changes * Fix rubocop offences Co-authored-by: Chris Nelson <git@chrisnelson.io>
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Unrestrict dry-types version and fix changes * Fix rubocop offences Co-authored-by: Chris Nelson <git@chrisnelson.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #65 added
faraday-encodingwhich triggered an update of other gems, includingdry-types. This caused some breakages so I limited the version, but this is causing issues when pulling the gem into our app.This PR removes the
dry-typesversion limit, updates the gems and fixes the breaking changes which were just a change in the exceptions raised for certain schema/validation failures.