Conversation
abreckner
approved these changes
Feb 8, 2022
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Specific error types for differentiation * Update version number
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Specific error types for differentiation * Update version number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently any error parsed from XPM is an instance of the base class
XpmRuby::Error, which means you can't specifically rescue these errors separately to other errors. This is a problem if say, you want to catch error in validating data from XPM but not catch other things like TokenExpired (because it's handled elsewhere).This change adds two new error classes to differentiate these errors. They still inherit from the same parent as before so it should be a non breaking change. I bumped the version too because I guess technically that's what we should do.