Merged
Conversation
rmustafin
reviewed
Jan 22, 2023
rmustafin
approved these changes
Jan 22, 2023
Contributor
rmustafin
left a comment
rmustafin
left a comment
There was a problem hiding this comment.
LGTM, one question about spec
rmustafin
reviewed
Jan 22, 2023
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Add Client GET /search action * Add specs and VCR cassettes for Client GET /search action * Update Gemfile.lock * Update to Ruby 3.1.3 * Bump gem version to 0.3.0
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Add Client GET /search action * Add specs and VCR cassettes for Client GET /search action * Update Gemfile.lock * Update to Ruby 3.1.3 * Bump gem version to 0.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent (What)
Add Client GET /search action
Motivation (Why)
So that we can find clients by name without iterating through the full list in our app code
Implementation (How)
Implement
XpmRuby::Client.searchlike.listexcept taking different params and using a different endpointConsequence
XpmRuby::Client.searchavailable for use