Enhance hex2bin tool with additional command-line options and update …#8
Merged
Enhance hex2bin tool with additional command-line options and update …#8
Conversation
…README - Added support for `--all` and `--record-bytes=N` flags in the hex2bin tool to control output behavior. - Updated main.go to handle new command-line arguments and improve usage instructions. - Enhanced README with detailed descriptions of new options and examples for usage. - Refactored BinToIntelHex function to BinToIntelHexWithMode for improved flexibility in data writing.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the hex2bin tool by introducing new command-line options to better control output behavior and updates its usage instructions and documentation.
- Added processing for the "--all" and "--record-bytes=N" flags in main.go.
- Refactored the BinToIntelHex function into BinToIntelHexWithMode to support adjustable output modes and record sizes.
- Updated README.md with detailed descriptions and examples for the new flags.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main.go | Updated argument parsing logic and usage instructions to support new flags. |
| converter/converter.go | Refactored the conversion function to accept new parameters for output control. |
| README.md | Enhanced documentation to include new command-line flag usage and examples. |
The BinToIntelHex function was not being used and has been removed to simplify the codebase. This eliminates redundant code and reduces potential maintenance overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…README
--alland--record-bytes=Nflags in the hex2bin tool to control output behavior.