Add ellipsis

[krlmlr]

#1028 (comment)

[krlmlr]

@ntamas: Works like a charm, idempotent, fd74ecf is an example of an added * . We'll wait for those to be available in the C core.

What does it take to add a check_dots_empty() call when a * is present in PARAMS?

[ntamas]

check_dots_empty() added in Stimulus 0.21.1.

[krlmlr]

Works as expected, in 8940156.

[szhorvat]

check_dots_empty()

Is this function waiting to be implemented? Let me know when that's done and I'll continue with #1028 afterwards.

[szhorvat]

Ah, so this is an rlang thing. Should it be called as rlang::check_dots_empty()? Or what is the solution to the following?

> k_shortest_paths(make_ring(5),1,2)
Error in check_dots_empty() : could not find function "check_dots_empty"

[szhorvat]

I guess I need to add #' @importFrom rlang check_dots_empty?

[krlmlr]

Thanks, missed that. Waiting for * to be configured in the core, eager to roll out here and run revdepchecks.

[krlmlr]

One more thing: in my book, the weights argument should always come after the ellipsis (if it exists, which I assume it will for most functions). This is contrary to https://github.com/igraph/igraph/wiki/Guidelines-for-function-argument-ordering .

#1028 (comment)

[ntamas]

The guidelines you cited above are for the C core. High-level interfaces are free to come up with their own guidelines in order to make the generated functions fit better with the conventions of the high-level language.

[krlmlr]

Could Stimulus take care of that for the autogenerated code? Do we agree it's a good idea?

[ntamas]

It could, but I'm not sure whether it's in the scope of the project.

I'd say that in the long term Stimulus should probably be refactored such that the repo contains the core only and the individual language-specific generators are in the repositories of the higher-level interfaces (with some kind of a plug-in system using Python's standard entry points from importlib). If that happens, you could do whatever you want with the R code generator as it would be entirely within your domain.