Improve top-level code in tests

[maelle]

For instance at the top of test-indexing there are two helper functions with names so short I find them unclear.

For top level code

• rename helper functions, save them in tests/testthat/helper- files
• move it to inside the tests.

[maelle]

What remains

test_files <- fs::dir_ls(fs::path("tests", "testthat"), regexp = "test-")

detect_top_level <- function(path) {
  lines <- brio::read_lines(path)
  lines <- lines[!startsWith(lines, "test_that")]
  top_level <- grep("^[a-zA-Z]", lines, value = TRUE)
  if (length(top_level) > 0) {
    print(path)
    print(top_level)
  }
}

purrr::walk(test_files, detect_top_level)
#> tests/testthat/test-embedding.R
#> [1] "standardize_eigen_signs <- function(x) {"
#> [2] "order_by_magnitude <- function(x) {"     
#> [3] "sort_by_magnitude <- function(x) {"      
#> tests/testthat/test-glet.R
#> [1] "sortgl <- function(x) {"                                             
#> [2] "threshold.net <- function(graph, level) {"                           
#> [3] "graphlets.old <- function(graph) {"                                  
#> [4] "graphlets.project.old <- function(graph, cliques, iter, Mu = NULL) {"
#> tests/testthat/test-operators.R
#>  [1] "A    1     a     a    1    A" "B    2     b     b    2    B"
#>  [3] "D    3     c    NA   NA    D" "E    4     d     c    3    E"
#>  [5] "C    5     e    NA   NA    C" "a  1 11    a"                
#>  [7] "b  2 12    b"                 "c  3 13    c"                
#>  [9] "d  4 14    d"                 "e  5 15    e"                
#> [11] "f  6 16    f"                 "g  7 17    g"                
#> [13] "h  8 18    h"                 "i  9 19    i"                
#> [15] "j 10 20    j"                 "k NA 21    k"                
#> [17] "l NA 22    l"                 "m NA 23    m"                
#> [19] "a  1 11    a"                 "b  2 12    b"                
#> [21] "c  3 13    c"                 "d  4 14    d"                
#> [23] "e  5 15    e"                 "f  6 16    f"                
#> [25] "g  7 17    g"                 "h  8 18    h"                
#> [27] "i  9 19    i"                 "j 10 20    j"                
#> [29] "a  1 11    a"                 "b  2 12    b"                
#> [31] "c  3 13    c"                 "d  4 14    d"                
#> [33] "e  5 15    e"                 "f  6 16    f"                
#> [35] "g  7 17    g"                 "h  8 18    h"                
#> [37] "i  9 19    i"                 "j 10 20    j"                
#> [39] "k NA 21    k"                 "l NA 22    l"                
#> [41] "m NA 23    m"                 "unique_tests <- list("       
#> tests/testthat/test-other.R
#> [1] "names <- c("          "karate <- structure("
#> tests/testthat/test-scan.R
#>  [1] "local_rng_version(\"3.5.0\")"          
#>  [2] "withr::local_seed(12345)"              
#>  [3] "n <- 10^3"                             
#>  [4] "p <- 0.1"                              
#>  [5] "g <- sample_gnp(n, p)"                 
#>  [6] "E(g)$weight <- sample(ecount(g))"      
#>  [7] "gp <- sample_gnp(n, p)"                
#>  [8] "E(gp)$weight <- sample(ecount(gp))"    
#>  [9] "withr::local_seed(42)"                 
#> [10] "n <- 10^3"                             
#> [11] "p <- 0.1"                              
#> [12] "g <- sample_gnp(n, p, directed = TRUE)"
#> [13] "E(g)$weight <- sample(ecount(g))"      
#> [14] "gp <- sample_gnp(n, p)"                
#> [15] "E(gp)$weight <- sample(ecount(gp))"

^{Created on 2025-07-16 with reprex v2.1.1}

[maelle]

@schochastics

• test-operators.R is a false positive of my script.
• tests/testthat/test-embedding.R defines its own functions, seems ok?
• same for tests/testthat/test-glet.R
• tests/testthat/test-other.R has top-level code towards the end, but the variables are used in two tests only. Is that fine so?

[schochastics]

To me this looks all fine. What about test-scan.R? Do you think this should be improved? If so I could do it in #1982

[maelle]

Oh right I forgot that one. If you can improve it, that would be great and we'd have one issue fewer. Thank you!!