Remove 'edges' parameter from as_adjacency_matrix()

[szhorvat]

The edges parameter of as_adjacency_matrix() was promised to be removed in igraph 1.4.0, but this did not happen.

There is a warning:

warning("The `edges` argument of `as_adjacency_matrix` is deprecated; it will be removed in igraph 1.4.0")

• Docs should mention the deprecation as well
• Update version in warning, as we're past 1.4.0
• Remove parameter

This parameter is still functional as of 1.4.3, but we won't be able to provide it with C/igraph 0.10. I suggest removal in 1.5.0.

[maelle]

So the edges argument needs to be slowly deprecated in [.igraph?

That is what the test failure in #1080 is.

[szhorvat]

C/igraph 0.10 does not support the edges parameter. If you want to keep it, it needs to be reimplemented in the R interface fully.

The original concept of this parameter was always somewhat broken in that it cannot support multi-edges, and it was only reasonable for 1-based indexing. It's also incompatible with granular loop control, introduced in 0.10.

[maelle]

Ok, makes sense! I'll fix up #1080 after #1085 is finished.

[krlmlr]

Done now.