graph.famous

[maelle]

A problem I'm having in #970 is that graph.famous() is deprecated to make_famous_graph() which isn't exported.

• what should the replacing call actually be?
• How should be graph.famous("zachary") and graph.famous("Levi") (from the tests) be adapted?

[maelle]

I made this commit: 4a0f972

Sounds reasonable?

[szhorvat]

It's just make_graph now with a string argument.

Sorry, I'm unable to check your commit at the moment

[szhorvat]

make_graph("Zachary")

[maelle]

ok, thanks, I used that, makes sense! 🙏

[szhorvat]

I could check your commit now. So the test just checked that make_graph gives the same as graph.famous. That seems a bit pointless, I agree to just remove it.

I'm in China for a while and my internet access is limited.

[maelle]

Thank you!

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.